Skip to content

Conversation

HannibalAPE
Copy link
Contributor

test data for opencv/opencv#17570

@alalek
Copy link
Member

alalek commented Jul 7, 2020

+130Mb

Not allowed.

Large files (models, >1Mb) for DNN should be stored on external resources (Google Drive, DropBox, OneDrive, etc).

Test images should be kept small (no need to store FullHD images in PNG format - 320x240 may be enough for regression test)

@HannibalAPE
Copy link
Contributor Author

HannibalAPE commented Jul 8, 2020

+130Mb

Not allowed.

Large files (models, >1Mb) for DNN should be stored on external resources (Google Drive, DropBox, OneDrive, etc).

Test images should be kept small (no need to store FullHD images in PNG format - 320x240 may be enough for regression test)

@alalek I have already uploaded the model weights to Google Drive:

  1. crnn.onnx: https://drive.google.com/file/d/1ooaLR-rkTl8jdpGy1DoQs0-X0lQsB6Fj/view?usp=sharing
  2. DB_IC15_resnet50.onnx: https://drive.google.com/file/d/1cmAs91yFRyC2LC3nTTBNNYooyEmb0i5t/view?usp=sharing
  3. DB_TD500_resnet50.onnx: https://drive.google.com/file/d/1_9KB6QkIghp2VNZti_dJ3Araz-nDZBsL/view?usp=sharing

Then, I should resize the test images, and only put the images to the new branch? How about the model weights?
Thanks in advance.

@alalek
Copy link
Member

alalek commented Jul 8, 2020

Put links on models weights into sample/documentation. So Users can download these files by using provided links.
In samples assume that these external files are located in the current folder.

For tests, see https://github.com/opencv/opencv_extra/blob/master/testdata/dnn/download_models.py (including this file history and related PRs). Use cvtest::findDataFile() with required=False (share on CI is updated manually, so files may missing)

@alalek
Copy link
Member

alalek commented Jul 8, 2020

Please squash commits to remove huge remove files from Git history.

@HannibalAPE
Copy link
Contributor Author

HannibalAPE commented Jul 8, 2020

Please squash commits to remove huge remove files from Git history.

@alalek
sorry, this is my first time to pull a request, and I am not sure whether I successfully squash my commits.
If I make a mistake again, can I just close this pr, and open a new one?

@alalek
Copy link
Member

alalek commented Jul 8, 2020

just close this

Do NOT do that. Just push your changes with "--force" option.

git reset --hard b9d7d2b83efe552b3eb43ea9311e1e53f01456dd
git push --force ...

@HannibalAPE
Copy link
Contributor Author

@alalek Thank you for your help.

@alalek alalek merged commit 1e9dd0e into opencv:master Dec 3, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants