Skip to content

Conversation

@Dhanwanth1803
Copy link
Contributor

@dkurt Sorry for closing the previous PR. Here are the changes that you asked for. Thank you.

@Dhanwanth1803
Copy link
Contributor Author

@dkurt Can you review my latest commit. I generated it for genTestData('crop', [1, 3, 5, 6], [1, 3, 3, 2]) . Thank you.

@dkurt
Copy link
Member

dkurt commented Dec 20, 2023

@Dhanwanth1803, please create a branch with a name feat-crop from feat-crop1 again and reopen PR. Make sure commit 198f2dd is pulled.

@asmorkalov asmorkalov merged commit f365138 into opencv:4.x Dec 22, 2023
asmorkalov pushed a commit to opencv/opencv that referenced this pull request Dec 22, 2023
Fixes #22747. Support [crop] configuration for DarkNet #24384

Request for comments. This is my first PR. 

**Merge with extra**: opencv/opencv_extra#1112

resolves #22747

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
Fixes opencv#22747. Support [crop] configuration for DarkNet opencv#24384

Request for comments. This is my first PR. 

**Merge with extra**: opencv/opencv_extra#1112

resolves opencv#22747

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants