[XIMGPROC] Fix Niblack thresholding #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise we get a failed assertion from OutputArray::create
- no for-loops - support all thresholding types - support any input image depth - add Doxygen comments
- read image as 1-channel grayscale - 3 trackers to control function parameters - K allowed to go to negative values (usually to detect black text on white bg)
amroamroamro
force-pushed
the
fix_niblack
branch
from
712dbe4 to
6c7a806
Compare
Contributor
|
Thank you! |
opencv-pushbot
pushed a commit
that referenced
this pull request
Feb 12, 2016
amroamroamro
added a commit
to kyamagu/mexopencv
that referenced
this pull request
Mar 13, 2017
bug was fixed in opencv/opencv_contrib#542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues raised by @mshabunin for #181 in the comments.
I updated the function code, added support for the other threshold types, and included the missing Doxygen comments in the header file.
I also expanded the sample demo with more trackbars to manipulate the thresholding parameters.