Skip to content

Conversation

@cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Jun 22, 2023

The minor version which is compared to the CUDART_VERSION inside cudacodec::VideoReader is an order of magnitude too big.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

@cudawarped the patch looks reasonable. Please enable more test cases then.

@cudawarped
Copy link
Contributor Author

@cudawarped the patch looks reasonable. Please enable more test cases then.

@asmorkalov this shouldn't affect the test cases that were failing in the other PR.

From that PR I noticed that your error message was coming from the wrong place. It should have been coming from the execution of functions which were only available in CUDA >= 10.2 but it was coming from those that were available in CUDA >=10.1 (the reverse would have been a problem but would have resulted in an error at compile time).

The failure when decoding sample_322x242_15frames.yuv420p.mpeg2video.mp4 should still exist as I suspect it is because the frame supplied to cvtFromNv12 is corrupt.

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 3d242a6 into opencv:4.x Jun 22, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants