Skip to content

Fix invalid memory access in wechat_qrcode byte segment decoding #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix invalid memory access in wechat_qrcode byte segment decoding #3479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58168b8
Fix invalid memory access in wechat_qrcode byte segment decoding
determ1ne Apr 24, 2023
70ed274
Fix data count repairation in wechat_qrcode byte segment decoding
determ1ne Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/wechat_qrcode/src/zxing/qrcode/decoder/decoded_bit_stream_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,10 @@ void DecodedBitStreamParser::decodeByteSegment(Ref<BitSource> bits_, string& res
int available = bits.available();
// try to repair count data if count data is invalid
if (count * 8 > available) {
count = (available + 7 / 8);
count = (available + 7) / 8;
}
// avoid reading invalid memory region when no data should be processed
if (count <= 0) return;

ArrayRef<char> bytes_(count);
char* readBytes = &(*bytes_)[0];
Expand Down