Skip to content

Conversation

@asmorkalov
Copy link
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov force-pushed the as/xcode_warning_supression branch from a9d9e36 to f149f26 Compare February 1, 2023 12:01
@alalek
Copy link
Member

alalek commented Feb 1, 2023

One more fix is required:

/Users/opencv-cn/GHA-OCV-1/_work/opencv_contrib/opencv_contrib/opencv_contrib/modules/ximgproc/src/brightedges.cpp:82:17: warning: variable 'lines' set but not used [-Wunused-but-set-variable]

@asmorkalov
Copy link
Contributor Author

@alalek The last warning is tricky. The issue looks like typo in code. Sample result before and after fix:
contast10
contast10_fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants