Skip to content

Conversation

@SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 16, 2023

alphamat header depends on InputArray, OutputArray and CV_EXPORTS_W but doesn't include related opencv2/core.hpp, so this header can break depending on include order.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this Jan 18, 2023
@opencv-pushbot opencv-pushbot merged commit d2581b4 into opencv:4.x Jan 21, 2023
@SpaceIm SpaceIm deleted the fix/alphamat-header branch January 21, 2023 18:36
@alalek alalek mentioned this pull request Jan 28, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants