Add RTSP features to cudacodec::VideoReader #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
May 25, 2022
asmorkalov
reviewed
May 26, 2022
asmorkalov
reviewed
May 27, 2022
Contributor
asmorkalov
left a comment
asmorkalov
left a comment
There was a problem hiding this comment.
Looks good to me in general, besides force flag in init. I propose to remove it at all.
Tested on Ubuntu 18.04 with CUDA 10.2, NVIDIA Video Codec SDK 11.1.
Contributor
Author
|
No you are correct. Force is not used and can be removed because it could be dangerous to have the facility to initialize a frameque object twice. It may be better if required in the future to have a specific reinitialization routine which performs safety checks, if the size of the que needs to be altered mid-decode. |
…t is for, which should be left up to the documentation.
…fe if another thread and/or object is using it.
cudawarped
force-pushed
the
videoreader_add_rtsp_feature
branch
from
9a2ad10 to
95fd837
Compare
asmorkalov
approved these changes
Jun 2, 2022
6 tasks
hakaboom
pushed a commit
to hakaboom/opencv_contrib
that referenced
this pull request
Jul 1, 2022
…eature Add RTSP features to cudacodec::VideoReader * Add live video source enhancements, e.g. rtsp from ip camera's Add error logs. * Fix type. * Change badly named flag. * Alter live source flag everywhere to indicate what it does not what it is for, which should be left up to the documentation. * Prevent frame que object from being reinitialized which could be unsafe if another thread and/or object is using it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the below two features to
cudacodec::VideoReaderto help when streaming from live sources.nextFrame()/grab()is less than the source FPS. Although this is something which a user would eventually accomodate for themselves (by reading at the appropriate rate and choosing which packets to discard) it would be a useful for this to be "automatic" until they have implemented that functionality.Testing - currently the additional tests only check that the new parameters have been set inside
VideoReaderand do not verify the functionality of (1) and (2). This is because testing (1) requires a new test video file (I am not sure if that is overkill for this small feature) and testing (2) require a live RTSP source. I can easily include an extra test file if required but I am not sure how I can simulate an live RTSP source?Patch to opencv_extra has the same branch name.