Skip to content

Conversation

@opencv-pushbot
Copy link
Contributor

#3200 from AleksandrPanov:aruco_improvements
#3219 from vrabaud:34_remove_unused
#3220 from buq2:aruco-apriltag-infinite-loop-fix
#3230 from AleksandrPanov:fix_ArucoThreading_test

Main PR: opencv/opencv#21878
Previous "Merge 3.4": #3221

vrabaud and others added 7 commits April 1, 2022 09:50
This is to quiet the -Wunused-but-set-parameter clang diagnostic warning.
…-fix

Fix infinite loop on ArUco apriltag refinement

* Fix infinite loop on ArUco apriltag refinement

Software entered infinite loop when image height
was smaller than 10*cv::getNumThreads(). With high
core count machines this could happen with very
reasonable image sizes.

Fix is to ensure that chunksize is at least 1.

* Test aruco detection with different number of threads

Test ensures that different aruco detection methods do not
produce different results based on number of threads.

Test was created after observing infinite loop caused
by small image and large number of threads when using
apriltag corner refinement.

* Test refactoring.

* Syntax fix for pre-C++11 compilers.

Co-authored-by: Alexander Smorkalov <[email protected]>
Aruco improvements

* add writeDictionary(), dict distance, fix readDictionary(), readDetectorParameters()

* add aruco_dict_utils.cpp

* add py test_write_read_dict

* update tutorial
…_test

Fix warning for Aruco threading test
@opencv-pushbot opencv-pushbot self-assigned this Apr 16, 2022
@opencv-pushbot opencv-pushbot merged commit b8e4061 into opencv:4.x Apr 16, 2022
@opencv-pushbot opencv-pushbot mentioned this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants