Add missing stride in cuda::LinearFilter::apply - #3163 #3167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aplies the fix identified by @yl070360 in #3163.
The stride information is currently missing inside
cuda::LinearFilter::apply()producing incorrect results whenGpuMat's are constructed using pointers to pre-allocated device memory.The current tests should to be sufficient to check this because they are wrongly passing at the moment due to another bug (see below) in the construction of
GpuMat's which can be fixed once this is merged.GpuMat Bug
GpuMat::dataendwrongly points to the last element of an alocated row instead of the last useable element of the ROI unless theGpuMatis constructed from a pointer to pre-allocated device memory.This means that
locateROI(wholeSize,ofs)currently returns the stride inwholeSizeinstead of the width of the ROI.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.