Skip to content

rgbd: colored kinfu - allow fetching colors for pointcloud #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

rgbd: colored kinfu - allow fetching colors for pointcloud #3121

merged 1 commit into from
Dec 7, 2021

Conversation

@paroj
Copy link
Contributor

@paroj paroj commented Nov 23, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

DumDereDum
DumDereDum requested changes Dec 1, 2021
View reviewed changes
savuor
savuor approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@savuor savuor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

DumDereDum
DumDereDum approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@DumDereDum DumDereDum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too

@opencv-pushbot opencv-pushbot merged commit 744a459 into opencv:4.x Dec 7, 2021
@alalek
Copy link
Member

alalek commented Dec 30, 2021

No way to automatically merge this to 5.x branch.
Dedicated PRs with porting this to 5.x branch is needed.

@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savuor savuor savuor approved these changes

@DumDereDum DumDereDum DumDereDum approved these changes

Assignees

@savuor savuor

Labels

category: rgbd feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paroj @alalek @savuor @DumDereDum @opencv-pushbot