Skip to content

Bugfix: barcode module #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from Apr 22, 2021
Merged

Bugfix: barcode module #2929

merged 3 commits into from Apr 22, 2021

Conversation

darkliang
Copy link
Contributor

@darkliang darkliang commented Apr 20, 2021 •
edited
Loading

We found three bugs recently:

  1. JNI crashing while coping vector<BarcodeType> to ArrayList<Integer>;
  2. In python/java, assertion fails when calling BarcodeDetector::decode();
  3. The implementation of UPCEANDecoder::decodeROI() is wrong.

We fixed up all the bugs, and wrote tests for python and java ports.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@darkliang
bugfix:
d5e3d01 
1. jni crashing while coping vector<BarcodeType> to list;
2. in python/java, assertion fails when calling decode(), because of (2D Mat).copyTo(vector<Point>);
3. the algorithm of decodeROI() is wrong.
@darkliang
add python and java tests
48b797b
@darkliang
use constexpr
c58ee78
@alalek alalek merged commit ff9b0a1 into opencv:master Apr 22, 2021
@alalek alalek mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@APrigarina APrigarina APrigarina approved these changes

Assignees

@APrigarina APrigarina

Labels

bug category: barcode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darkliang @APrigarina @alalek