Skip to content

Conversation

Sintun
Copy link

@Sintun Sintun commented Feb 7, 2021

fixes #2662

This PR fixes the usage of uninitialized memory that can lead to throws and segfaults.

I think the original author wanted to add ones to a zero-initialized Mat object.
I could have used another Constructor for the Mat object, but i chose to make the minimal amount of changes to the code to work as intended.

My proposed change does not change the used algorithm.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@opencv-pushbot opencv-pushbot merged commit eaa4f33 into opencv:master Feb 7, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage of uninitialized memory in module alphamat leads to unexpected behavior.

3 participants