1D Barcode support #2757

Certseeds · 2020-11-19T07:55:07Z

Merge with extra: opencv/opencv_extra#860

test_modules=barcode

opencv_extra=Barcode

Signed-off-by: Killer_Quinn <[email protected]>

Certseeds · 2020-12-01T05:06:15Z

The building bot ~~is waiting for builds for a few days.Before it~~ builds successfully, would anyone like to Review our class interface in barcode.hpp?

modules/barcode/include/opencv2/barcode.hpp

…oint2f>>, barcodeDirectly now just output one string, this commit is still only contain interface, barcode module will not be compile. Signed-off-by: Killer_Quinn <[email protected]>

darkliang · 2021-01-04T18:36:44Z

Now, we pushed the implementation code that was tested in Raspberry Pi 4B and win64.

JinhengZhang · 2021-01-13T09:23:20Z

@alalek @vpisarev Please, have a review. Thank you!

darkliang · 2021-01-13T09:25:17Z

@alalek Hi, I thought our interface code was written in correct format, but there is no our class(BarcodeDetector) in the generated Python bindings. The Python interpreter shows:

PS C:\WINDOWS\System32> python
Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import cv2.barcode as barcode
>>> barcode.BarcodeDetector()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'cv2.barcode' has no attribute 'BarcodeDetector'
>>> dir(barcode)
['EAN_13', 'EAN_8', 'NONE', 'UPC_A', 'UPC_E', 'UPC_EAN_EXTENSION', '__doc__', '__loader__', '__name__', '__package__', '__spec__']

Can you help us for this?

vpisarev · 2021-01-22T09:31:14Z

thank you for the contribution! Could you please implement some regression tests and add example in C++ or Python that uses this functionality?

darkliang · 2021-01-27T02:20:03Z

@alalek Hi, we added the tests and sample, but tests failed because test data was not merged into opencv_extra. Can you fix it?

alalek · 2021-02-11T21:27:03Z

opencv_extra PR must be created from the same "user" GitHub account and use the same source branch name as "main" PR (to run validation).

darkliang · 2021-03-29T10:56:56Z

@alalek Hi, we think our PR is ready to review. As mentioned above, we still have not resolved this issue. Can you look into this?

alalek

Thank you for the contribution!

modules/barcode/src/detector/bardetect.cpp

modules/barcode/tutorials/barcode_detect_and_decode/barcode_detect_and_decode.markdown

…pp files

darkliang · 2021-04-06T12:49:09Z

Thank you for the contribution!

Thanks for review, we have updated the code again. By the way, we figured out the usage of generated python code, it should be cv.barcode_BarcodeDetector().

vpisarev · 2021-04-15T11:58:44Z

👍

alalek

Great contribution!

Please take a look on the comments below.

modules/barcode/samples/barcode.cpp

alalek · 2021-04-15T19:03:34Z

modules/barcode/misc/java/src/cpp/barcode_converters.hpp

+// Author: darkliang
+
+#ifndef BARCODE_CONVERTERS_HPP
+#define	BARCODE_CONVERTERS_HPP


please remove tabs from source code files

modules/barcode/samples/barcode.cpp

alalek · 2021-04-15T19:11:28Z

modules/barcode/src/decoder/upcean_decoder.cpp

+//void UPCEANDecoder::drawDebugLine(Mat &debug_img, const Point2i &begin, const Point2i &end) const
+//{
+//    Result result;
+//    std::vector<uchar> middle;


//

Instead of using of multi-line comments, consider using of #if 0 to disable debug parts in the code.

modules/barcode/src/decoder/upcean_decoder.cpp

modules/barcode/src/detector/bardetect.cpp

alalek · 2021-04-15T19:45:30Z

modules/barcode/src/detector/bardetect.cpp

+    // calculate magnitude of gradient, normalize and threshold
+    magnitude(scharr_x, scharr_y, gradient_magnitude);
+    threshold(gradient_magnitude, gradient_magnitude, 56, 1, THRESH_BINARY);
+    gradient_magnitude.convertTo(gradient_magnitude, CV_8U);


It is better to avoid in-placing of in/out parameters.
Especially with different types.

It is better to avoid in-placing of in/out parameters.
Especially with different types.

I did not really understand what's your point? I rewrote the code like this:

magnitude(scharr_x, scharr_y, temp); threshold(temp, temp, THRESHOLD_MAGNITUDE, 1, THRESH_BINARY); temp.convertTo(gradient_magnitude, CV_8U);

modules/barcode/src/detector/bardetect.cpp

alalek · 2021-04-15T19:51:10Z

modules/barcode/src/detector/bardetect.cpp

+            pt = Point(x, y);
+            cur_value = orientation.at<float_t>(pt);
+            sin_sum = sin(2 * cur_value);
+            cos_sum = cos(2 * cur_value);


BTW, in general sin/cos computation in nested loops is not very cheap.

BTW, in general sin/cos computation in nested loops is not very cheap.

Do you have some suggestion for this? I analyzed the performance by Visual Studio, found that

It seems like preprocess() is much more time-consuming than this.

Thank you for checking this.
You are right, this is not critical part of computations for now.

Possible optimization are usually done through using of pre-computed sin/cos tables (with input value quantization).

modules/barcode/samples/barcode.cpp

darkliang · 2021-04-16T06:36:20Z

Based on your comments, I refined the code. Please check again. @alalek @vpisarev

alalek

Well done! Thank you 👍

darkliang · 2021-04-16T10:34:41Z

Well done! Thank you 👍

@alalek Thanks for your review. I fixed up a bug about java binding, please check. 😆

init barcode interface.

3a9120a

darkliang force-pushed the Barcode-Support branch from 562484d to 3a9120a Compare November 19, 2020 08:01

barcode: update readme.

2167cc9

darkliang force-pushed the Barcode-Support branch from e157215 to 2167cc9 Compare November 19, 2020 08:49

Certseeds added 2 commits November 26, 2020 16:14

now it is just interface, do not need CMakeLists to compiler it.

55aa90f

Signed-off-by: Killer_Quinn <[email protected]>

fix-trailing whitespace of docs-build.

8914da9

Signed-off-by: Killer_Quinn <[email protected]>

alalek reviewed Dec 5, 2020

View reviewed changes

modules/barcode/include/opencv2/barcode.hpp Outdated Show resolved Hide resolved

modules/barcode/include/opencv2/barcode.hpp Outdated Show resolved Hide resolved

Certseeds and others added 5 commits December 9, 2020 22:26

Branch: Barcode-Support,replace vector<RotateRect> to vector<vector<P…

ad603e0

…oint2f>>, barcodeDirectly now just output one string, this commit is still only contain interface, barcode module will not be compile. Signed-off-by: Killer_Quinn <[email protected]>

add implementation details

23684ec

fix doc bug

86320bb

not generate python bindings temporarily

de5bd88

add barcode group for doxygen

457e1b4

Certseeds marked this pull request as ready for review January 6, 2021 14:36

Certseeds changed the title ~~[WIP] 1D Barcode support~~ 1D Barcode support Jan 6, 2021

generate python bindings and improve performance

b8f0115

darkliang force-pushed the Barcode-Support branch from f0e55d2 to b8f0115 Compare January 9, 2021 10:36

darkliang added 2 commits January 12, 2021 15:24

remove win10 build warnings in detect stage

e81d975

remove win10 build warnings on decode stage

2349a10

WangberlinT mentioned this pull request Jan 26, 2021

barcode test images opencv/opencv_extra#839

Open

darkliang force-pushed the Barcode-Support branch 2 times, most recently from c952114 to 69faf4d Compare January 26, 2021 16:00

add samples and accuracy tests

4ae4d1b

darkliang force-pushed the Barcode-Support branch from 69faf4d to 4ae4d1b Compare January 27, 2021 02:29

delete decodeDirectly api for simplicity

ab59fa7

alalek reviewed Mar 30, 2021

View reviewed changes

modules/barcode/src/detector/bardetect.cpp Show resolved Hide resolved

modules/barcode/tutorials/barcode_detect_and_decode/barcode_detect_and_decode.markdown Outdated Show resolved Hide resolved

darkliang force-pushed the Barcode-Support branch from 6894335 to aa3b707 Compare April 4, 2021 16:36

add super resolution and optimize code format

dde14f0

darkliang force-pushed the Barcode-Support branch from aa3b707 to 30aedeb Compare April 6, 2021 12:07

Use @snippet / @include doxygen statements for embedding code from .c…

94d38d5

…pp files

darkliang force-pushed the Barcode-Support branch from 30aedeb to 94d38d5 Compare April 6, 2021 12:40

darkliang added 2 commits April 7, 2021 19:50

improve decoding performance

263070e

optimize code and slightly improve the performance

1b1c54d

darkliang force-pushed the Barcode-Support branch from 6c5cd95 to 1b1c54d Compare April 8, 2021 15:27

darkliang added 2 commits April 10, 2021 20:06

add ean8 support

fa9fa31

add references and use uint type for some non-negative variables

43e6e6f

darkliang force-pushed the Barcode-Support branch from e1c7132 to 43e6e6f Compare April 13, 2021 11:10

darkliang added 2 commits April 14, 2021 21:23

support java bindings

585ecb5

optimize wording in source code and documentation

ba8367d

vpisarev self-assigned this Apr 15, 2021

alalek reviewed Apr 15, 2021

View reviewed changes

refine code

afab937

whitespace

68f55c3

alalek approved these changes Apr 16, 2021

View reviewed changes

bugfix: forget to clear list

1fe3ca1

alalek merged commit e673aa4 into opencv:master Apr 16, 2021

alalek mentioned this pull request Jun 4, 2021

(5.x) Merge 4.x #2966

Merged

alalek mentioned this pull request Jan 16, 2022

When to support all 1 D code types #3088

Closed

n0099 mentioned this pull request May 29, 2023

Missing port of cv::barcode::BarcodeDetector, which is introduced in OpenCV 4.5.3 shimat/opencvsharp#1574

Closed

1D Barcode support #2757

1D Barcode support #2757

Uh oh!

Conversation

Certseeds commented Nov 19, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Certseeds commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

darkliang commented Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JinhengZhang commented Jan 13, 2021

Uh oh!

darkliang commented Jan 13, 2021

Uh oh!

vpisarev commented Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darkliang commented Jan 27, 2021

Uh oh!

alalek commented Feb 11, 2021

Uh oh!

darkliang commented Mar 29, 2021

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

darkliang commented Apr 6, 2021

Uh oh!

vpisarev commented Apr 15, 2021

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalek Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalek Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alalek Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

darkliang Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alalek Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

darkliang Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek Apr 16, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darkliang commented Apr 16, 2021

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

darkliang commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Certseeds commented Nov 19, 2020 •

edited by alalek

Loading

Certseeds commented Dec 1, 2020 •

edited

Loading

darkliang commented Jan 4, 2021 •

edited

Loading

vpisarev commented Jan 22, 2021 •

edited

Loading

darkliang Apr 16, 2021 •

edited

Loading

darkliang Apr 16, 2021 •

edited

Loading

darkliang commented Apr 16, 2021 •

edited

Loading