Fix Detection of ArUco Markers tutorial #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
dbd6b67 to
039439b
Compare
|
The checks fail because the Docs build is showing a warning that the patch size is 1465 KiB, but it's not taking into account that the files being replaced are basically the same size. The total increase in size of the images directory is 57,477 bytes. |
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
039439b to
0bdac98
Compare
SSteve
force-pushed
the
aruco_tutorial_fix
branch
2 times, most recently
from
d18669a to
8cc282e
Compare
|
Thank you for contribution! Please avoid using PNG for real-life images (like For bitmask-like or diagrams images please use PNG format, but ensure that there is no noise ( |
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
8cc282e to
b6ec091
Compare
|
I replaced real-life PNG images with JPEG. I binarized the underlying grayscale image in |
alalek
reviewed
Dec 2, 2019
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
b6ec091 to
b1d642c
Compare
alalek
reviewed
Dec 3, 2019
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
b1d642c to
4f7936f
Compare
alalek
approved these changes
Dec 5, 2019
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
modules/aruco/tutorials/aruco_detection/aruco_detection.markdown
Outdated
Show resolved
Hide resolved
… `DICT_6X6_250` dictionary.
SSteve
force-pushed
the
aruco_tutorial_fix
branch
from
4f7936f to
93258b3
Compare
opencv-pushbot
pushed a commit
that referenced
this pull request
Dec 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Detection of ArUco Markers tutorial to use current version of
DICT_6X6_250dictionary.force_builders_only=Docsresolves #1845
This pullrequest changes
DICT_6X6_250dictionary.