- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.9k
Added constructors and destructors for RgbdPlane #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some simple test to check fixed Python bindings. Example of Python test.
| Thanks for the comments and reviews. Is it possible to obtain the paper which was referred for implementing  | 
| I have asked the question about references here and #10 (comment) | 
ebefc7a    to
    e7cfe52      
    Compare
  
    | @czgdp1807 I found some references in ..\rgbd\src\plane.cpp, 
 It may help you. 
 | 
| I just defined the constructors/destructors and below is the result, Python 3.6.8 (default, Oct  7 2019, 12:59:55) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cv2
>>> rgbd_plane = cv2.rgbd.RgbdPlane_create(cv2.rgbd.RgbdPlane_RGBD_PLANE_METHOD_DEFAULT, 40, 1600, 0.01, 0, 0, 0)
>>> rgbd_plane
<rgbd_RgbdPlane 0x7f5b931f5c50>
>>> I will add the test for python bindings by tomorrow and will push the final changes here. | 
e7cfe52    to
    e57b970      
    Compare
  
    b3168b4    to
    0c031b3      
    Compare
  
    | ping @alalek Please take a look and let me know of any changes required. Thanks. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for update! Looks good.
| Thanks for pointing out. I will make changes to the tests. | 
0c031b3    to
    1157b26      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thank you 👍
1157b26    to
    30be198      
    Compare
  
    | return makePtr<DepthCleaner>(depth_in, window_size_in, method_in); | ||
| } | ||
|  | ||
| RgbdPlane::RgbdPlane(int method, int block_size, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These definitions should be placed in plane.cpp (like other RgbdPlane methods)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that in a new PR.
resolves #2277
This pullrequest changes
This PR adds constructors and destructors for RgbdPlane class.