Skip to content

Conversation

@czgdp1807
Copy link
Contributor

resolves #2277

This pullrequest changes

This PR adds constructors and destructors for RgbdPlane class.

@czgdp1807
Copy link
Contributor Author

I will add the definitions for each one of them once their API is approved.
ping @Takugo @alalek Please take a look and let me know if you want some modifications.

@czgdp1807 czgdp1807 changed the title declared constructors and destructors of RgbdPlane [WIP] Added constructors and destructors for RgbdPlane Nov 8, 2019
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some simple test to check fixed Python bindings. Example of Python test.

@czgdp1807
Copy link
Contributor Author

Thanks for the comments and reviews. Is it possible to obtain the paper which was referred for implementing RgbdPlane class? If not available, please share any valid literature which can cited in the documentation.

@czgdp1807
Copy link
Contributor Author

I have asked the question about references here and #10 (comment)

@Takugo
Copy link

Takugo commented Nov 14, 2019

@czgdp1807 I found some references in ..\rgbd\src\plane.cpp,
RgbdPlane() may be implemented referring to papers below:

/** This is an implementation of a fast plane detection loosely inspired by

  • Fast Plane Detection and Polygonalization in noisy 3D Range Images
  • Jann Poppinga, Narunas Vaskevicius, Andreas Birk, and Kaustubh Pathak
  • and the follow-up
  • Fast Plane Detection for SLAM from Noisy Range Images in
  • Both Structured and Unstructured Environments
  • Junhao Xiao, Jianhua Zhang and Jianwei Zhang
  • Houxiang Zhang and Hans Petter Hildre
    */

It may help you.

Thanks for the comments and reviews. Is it possible to obtain the paper which was referred for implementing RgbdPlane class? If not available, please share any valid literature which can cited in the documentation.

@czgdp1807
Copy link
Contributor Author

I just defined the constructors/destructors and below is the result,

Python 3.6.8 (default, Oct  7 2019, 12:59:55) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cv2
>>> rgbd_plane = cv2.rgbd.RgbdPlane_create(cv2.rgbd.RgbdPlane_RGBD_PLANE_METHOD_DEFAULT, 40, 1600, 0.01, 0, 0, 0)
>>> rgbd_plane
<rgbd_RgbdPlane 0x7f5b931f5c50>
>>> 

I will add the test for python bindings by tomorrow and will push the final changes here.

@czgdp1807
Copy link
Contributor Author

ping @alalek Please take a look and let me know of any changes required. Thanks.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update! Looks good.

@czgdp1807
Copy link
Contributor Author

Thanks for pointing out. I will make changes to the tests.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@czgdp1807 czgdp1807 changed the title [WIP] Added constructors and destructors for RgbdPlane Added constructors and destructors for RgbdPlane Nov 19, 2019
@alalek alalek merged commit b3ad2c3 into opencv:3.4 Nov 19, 2019
return makePtr<DepthCleaner>(depth_in, window_size_in, method_in);
}

RgbdPlane::RgbdPlane(int method, int block_size,
Copy link
Member

@alalek alalek Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These definitions should be placed in plane.cpp (like other RgbdPlane methods)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do that in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants