Added LookAt-methods and a GetPose-method for entities #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paroj
suggested changes
Jun 30, 2019
| * @param tvec translation vector | ||
| * @param invert return the inverted pose | ||
| */ | ||
| CV_WRAP virtual void getEntityPose(const String& name, OutputArray R, OutputArray tvec, bool invert) = 0; |
There was a problem hiding this comment.
add default arguments as in getCameraPose. This is useful with python.
| * @param origin entity name | ||
| * @param target targetpoint vector | ||
| */ | ||
| CV_WRAP virtual void setEntityLookAt(const String& origin, InputArray target) = 0; |
There was a problem hiding this comment.
combine both functions into one as in setCameraLookAt to allow an lookAt offset. Then you can implement lookat for an arbitrary destination if target == "".
modules/ovis/src/ovis.cpp
Outdated
| void setEntityLookAt(const String& origin, InputArray target) CV_OVERRIDE | ||
| { | ||
|
|
||
| SceneNode* or = sceneMgr->getEntity(origin)->getParentSceneNode(); |
There was a problem hiding this comment.
as the diff suggests or is a bad variable name
AlexJ95
force-pushed
the
ovis-add-entity-LookAt
branch
from
cd6d8da to
51b16a8
Compare
|
@alalek 👍 |
alalek
approved these changes
Jul 2, 2019
opencv-pushbot
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
This PR adds 2 overloaded methods setEntityLookAt, which add the option to make an entity look at another one or at a given point in world coordinates.
Also it adds a GetEntityPose method, which just was missing. It gives you the position and rotation of an entity.
Tested on:
OpenCV => 4.1.0
Operating System / Platform => Windows 10 64 Bit
Compiler => Visual Studio 2017