Skip to content

Conversation

@krutikabapat
Copy link
Contributor

@krutikabapat krutikabapat commented Feb 16, 2019

This pullrequest changes

FaceRecognizer::train(InputArrayOfArrays src, InputArray labels); 

The type InputArray can accept vector<T> or Mat types as mentioned here: https://docs.opencv.org/3.4/d4/d32/classcv_1_1__InputArray.html

Also added the way of using Mat for labels. (with type CV_32SC1)

force_builders=Docs

@alalek
Copy link
Member

alalek commented May 20, 2019

As a "bugfix" this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@krutikabapat krutikabapat changed the base branch from master to 3.4 May 23, 2019 04:19
Resolves Issue opencv#1997

``` FaceRecognizer::train(InputArrayOfArrays src, InputArray labels); ```

The type `InputArray` can accept `vector<T>` or `Mat` types as mentioned here: https://docs.opencv.org/3.4/d4/d32/classcv_1_1__InputArray.html
@krutikabapat
Copy link
Contributor Author

@alalek - Thanks! I've changed the branch to 3.4 from master, re-based commits to 3.4 and force pushed the changes.

@alalek alalek merged commit 9005e9e into opencv:3.4 May 23, 2019
@alalek alalek mentioned this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update, does not affect code category: face

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants