Bug fixing #196
Merged
Bug fixing #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused header
|
It is always good to explain why you are changing the values of the tld tracker or link to a issue on the bug tracker! |
modules/tracking/src/precomp.hpp
Outdated
There was a problem hiding this comment.
If it is not needed, then it is not needed. I don't really see the point of having dead code (especially with includes).
There was a problem hiding this comment.
Actually this is quite obvious :) The other change isn't :)
There was a problem hiding this comment.
I agree. Anyway, I meant this line should me removed rather than commented.
Contributor
Author
|
Sorry for late respond. I pulled out the description of bug to comments and deleted unused header |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug has the same origin as:
#187
The problem was in "fast" version of function generating a binary code for ensemble classifier posterior probability calculation. Bug was eliminated by fixing the order of "values" in offsets calculating function