Skip to content

Conversation

@paroj
Copy link
Contributor

@paroj paroj commented Jun 21, 2018

for this

  • move Params struct out of class
  • use static create instead of pimpl
  • allow demo to be compiled without VIZ

@paroj paroj force-pushed the kinfupy branch 3 times, most recently from 0b93542 to ccfce24 Compare June 23, 2018 13:23
@savuor savuor self-assigned this Jun 25, 2018
@savuor
Copy link
Contributor

savuor commented Jun 25, 2018

Thank you for the PR
Can you resolve the conflicts? I've rewritten the demo a bit recently.

for this
- move Params struct out of class
- use static create instead of pimpl
- allow demo to be compiled without VIZ
@vpisarev
Copy link
Contributor

thank you! 👍

@vpisarev vpisarev self-assigned this Jun 25, 2018
@opencv-pushbot opencv-pushbot merged commit 9e78737 into opencv:master Jun 25, 2018
opencv-pushbot pushed a commit that referenced this pull request Jun 25, 2018
@paroj paroj deleted the kinfupy branch November 27, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants