Skip to content

Conversation

@cbalint13
Copy link
Contributor

This PR implements AGAST detector [1].

Reasons:

  • AGAST is faster than FAST, and is an good alternative to have among FAST and Harris.
  • AGAST has much better scoring routines, also have more testing/scoring patterns.
  • Some other detector e.g. BRISK depends on it see [2] and [3] bug reports.
  • Original code ported here is BSD license (compatible), and can be found at [4].
  • This PR also updates test, perftest and doc, i tried to follow actual FAST implementation 1:1
  • This PR has all proper citation in respect with the authors.
  • This PR follows opencv of my very best try, i hope it gets accepted at all.

[1] http://www6.in.tum.de/Main/ResearchAgast
[2] http://code.opencv.org/issues/3976
[3] http://code.opencv.org/issues/2491
[4] http://sourceforge.net/projects/agastpp/

This PR rebase #128 (automaticaly closed due to repository vanish).

@vpisarev vpisarev self-assigned this Apr 3, 2015
@vpisarev
Copy link
Contributor

vpisarev commented Apr 3, 2015

@cbalint13, terribly sorry for big delay; the code looks very nice. I'm basically ready to merge it in. The only request is - can you convert .rst docs to Doxygen comments? We got rid of RST in favor of Doxygen/Markdown sometime ago

@cbalint13
Copy link
Contributor Author

@vpisarev ,

  • Yes, i will fix it, allow me couple of hours, i will ping you once its done.

@cbalint13
Copy link
Contributor Author

@vpisarev ,

  • It is done, also PR rebased against upstream master.

@vpisarev
Copy link
Contributor

vpisarev commented Apr 5, 2015

👍

vpisarev added a commit that referenced this pull request Apr 5, 2015
@vpisarev vpisarev merged commit ae7e5a5 into opencv:master Apr 5, 2015
@cbalint13 cbalint13 deleted the agast branch April 6, 2015 03:16
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants