update structured_edge_detection #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update structured_edge_detection to read models from updated p. dollar toolbox
casting size_t to int
yarglawaldeg
commented
Mar 21, 2018
alalek
reviewed
Mar 21, 2018
| int finish = __rf.edgeBoundaries[currentNode + 1]; | ||
| size_t sizeBoundaries = __rf.edgeBoundaries.size(); | ||
| int convertedBoundaries = static_cast<int>(sizeBoundaries); | ||
| int nBnds = (convertedBoundaries - 1) / (nTreesNodes * nTrees); |
There was a problem hiding this comment.
Looks like nBnds is a constant for these loops (so it should be moved out).
Does "((convertedBoundaries - 1) % (nTreesNodes * nTrees)) == 0" always (remainder == 0)?
Or should we calculate original expression exactly (multiplication at first): currentNode * (convertedBoundaries - 1) / (nTreesNodes * nTrees)?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update structured_edge_detection to read models from updated p. dollar toolbox
This pullrequest changes
current version returns blurry edge map with "new" models from updated p. dollar toolbox
the solution can be to set sharpen parameter from the models to 0 and update the structured_edge_detection.cpp file as suggested here : http://answers.opencv.org/question/72962/trained-model-for-opencv-structured-edge-detection/?answer=95989#post-id-95989