Added automatically generated C bindings and raw Haskell bindings. #15
Conversation
…s in favor of letting cmake find the dependency.
….so, and symbols have been verified with nm.
…s and sources for the C wrappers.
…nking strategies (necessary for e.g. haskell's build system).
…g that it will require copying on the other side to pull off correctly. May undo this commit later in favor of moving the unsafePerformIOs into the higher level library.
|
Is there some problem with this PR? I was told to send it here a long time ago by @SpecLad and @kirill-kornyakov. |
Changed size.hpp and size.cpp to use double instead of int by default.
Now using macros to automatically generate code for the various element types that points can accept. While I'm only committing code for int/float/double, support can now trivially be extended to any type you might like to store in a cv::Point_<>.
|
Arjun, thank you for the pull request, but we need some time to check it. We're quite busy at the moment, but I hope to respond you in a week. Sorry for the delay... |
|
Thanks Kirill, hadn't heard anything in weeks ago I wasn't sure what was
|
Some functions are generated incorrectly by the generator, and others are skipped entirely.
This commit provides files to add those functions correctly. Functions added to
excluded_functions.{cpp,hpp} need to also be added to the excluded_functions list
in genc.py so the functions aren't generated into opencv_generated.{hpp,cpp}
thereby avoiding conflicts at build time.
Points are exposed in OpenCV via templated (generic) types. These types don't translate well to C and so Haskell sees them as a variety of different types. While we're able to unify them in Haskell again via data families, a similar naming scheme helps by allowing the compiler to automatically generate the appropriate function calls via Template Haskell.
…otatedRect_size,cv_RotatedRect_center,cv_create_RotatedRect,cv_inRangeS,cv_createTrackbar,cv_setMouseCallback excluded_functions.cpp
…otatedRect_size,cv_RotatedRect_center,cv_create_RotatedRect,cv_inRangeS,cv_createTrackbar,cv_setMouseCallback excluded_functions.cpp
…otatedRect_size,cv_RotatedRect_center,cv_create_RotatedRect,cv_inRangeS,cv_createTrackbar,cv_setMouseCallback to excluded_functions
… cv_destruct_Mat cv_delete_MatExpr cv_destruct_MatExpr to mat.cpp
… cv_destruct_Mat cv_delete_MatExpr cv_destruct_MatExpr to mat.cpp
Sending over excluded_functions.cpp/hpp and scalar.cpp/hpp for evaluation
|
@kirill-kornyakov -- Any updates for me? |
|
Well, I didn't have a chance to try your pull request, but it seems I will not be able to work on this before May (we have internal release in April). So, I suggest to take your pull request as is, and update it later if needed. Do you think you have finished with your work? I can merge your code as soon as you say me to do so. |
|
Merge next week then, I'm testing a couple of bug fixes and changes to the generator to handle InputArray and OutputArray a bit better. I should have it sorted out by then, and it'll be in a place where other people can reliably test. |
Still need to add Size.
This should fix memory management within the generated headers.
That's going to have to be done on a per-type level.
…rams because the generator was unable to generate these functions
…rams because the generator was unable to generate these functions
Add MLP_TrainParams stuff the generator was getting wrong.
Added new vignette and warmify samples
|
I see this is approaching a year old and bit-rotted. Is there a reason, other than time constraints, that the PR never made it upstream? Would now be a good time to de-bit-rot and resubmit? |
|
Sorry about the delay in responding, this got lost with the holidays and It's been almost entirely time constraints that have prevented me from Thanks, On Fri, Dec 26, 2014 at 6:42 PM, Thomas M. DuBuisson <
|
|
hi, will this P.R. updated for opencv3? |
|
@autosquid: It's unlikely I'll have time to devote to de-bitrotting this project before the spring. Feel free to pick it up if you'd like to see it included. |
* Fixing Windows build issue * Fix windows build and nodelet lib search
5 participants
This pull request is based on advice from this pull request. This PR adds automatically generated C bindings that mirror the C++ API and raw Haskell bindings that map onto those C bindings. Please see the description in the linked PR for full details.