Skip to content

Conversation

@BKNio
Copy link

@BKNio BKNio commented Nov 9, 2014

reworked PR #3

@BKNio
Copy link
Author

BKNio commented Nov 9, 2014

@vpisarev @mshabunin
reworked interface

@vpisarev
Copy link
Contributor

@BKNio, the new API looks great! We are almost ready to merge it in. Can you please also update the docs?

@vpisarev vpisarev mentioned this pull request Nov 10, 2014
@vpisarev
Copy link
Contributor

@BKNio, can you also, please, mention in the copyright section the authors of the original code, Eugene Kozhinov and other NNSU guys?

@BKNio BKNio force-pushed the lsvm_develop branch 2 times, most recently from 4a01258 to 4a58339 Compare November 10, 2014 19:29
reworked PR 3

comment off #include "opencv2/core/private.hpp". It prevent the project from being referenced from outside the opencv library.

renaming + docs;
@BKNio
Copy link
Author

BKNio commented Nov 10, 2014

@vpisarev fixed

@vpisarev
Copy link
Contributor

thanks! 👍

vpisarev added a commit that referenced this pull request Nov 13, 2014
@vpisarev vpisarev merged commit 9a0cc98 into opencv:master Nov 13, 2014
allnes pushed a commit to allnes/opencv_contrib that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants