Fixing convergence and divergence in edge_population_stats.py #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y need some updates to test divergence on CircuitNodeId
|
Ahoy; long time no talk. Thanks for the PR; I'm surprised that there is a mismatch there. |
|
Hi Mike! Thank you for taking a look into it. I made the final pull request after clearing as much as I could, but the fact I am running on py3.11 may have make me miss that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as I was doing my analysis I encountered issues in the divergence and convergence methods.
I made the following changes for it to work.
Thank you for your review!