Adds assets pagination

[juanjosegarcan]

Adapts asset service to router_read_many approach standardizing and getting by its pagination system

[juanjosegarcan]

@GianlucaFicarelli Take a look please. The only problem now is test_get_entity_assets is failing cause now when not entity or assets found is just giving back and empty page instead of 404 error. Should I change the test or give back 404 when empty page?

[GianlucaFicarelli]

@GianlucaFicarelli Take a look please. The only problem now is test_get_entity_assets is failing cause now when not entity or assets found is just giving back and empty page instead of 404 error. Should I change the test or give back 404 when empty page?

I was expecting an error when calling /{entity_route}/{entity_id}/assets and entity_id doesn't exist. If we'll need to return 404 we could execute an additional query on the entity when there aren't results.
However, the endpoint /{entity_route}/{entity_id}/derived-from has the same behaviour of returning an empty list, so I think it's ok to return the empty list for the moment since it's simpler, and the client should already know if the entity exists and it's accessible after hitting the /{entity_route}/{entity_id} endpoint.

[juanjosegarcan]

@GianlucaFicarelli Take a look please. The only problem now is test_get_entity_assets is failing cause now when not entity or assets found is just giving back and empty page instead of 404 error. Should I change the test or give back 404 when empty page?

I was expecting an error when calling /{entity_route}/{entity_id}/assets and entity_id doesn't exist. If we'll need to return 404 we could execute an additional query on the entity when there aren't results. However, the endpoint /{entity_route}/{entity_id}/derived-from has the same behaviour of returning an empty list, so I think it's ok to return the empty list for the moment since it's simpler, and the client should already know if the entity exists and it's accessible after hitting the /{entity_route}/{entity_id} endpoint.

I changed the failing test to accept an empty list as entity not found

[GianlucaFicarelli]

LGTM

[juanjosegarcan]

I'll wait if @eleftherioszisis and @mgeplf have any comment!

[mgeplf]

looks reasonable to me

[juanjosegarcan]

@eleftherioszisis @GianlucaFicarelli @mgeplf I set back the authorization check for get_assets and added tests to verify authorization

[mgeplf]

good call on testing non-authorized.
I wonder if the non-authorization tests can be moved to separate tests, and parameterized also on user_context_no_project

[juanjosegarcan]

Done

[mgeplf]

LGTM