Skip to content

Add external data source #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 20, 2025
Merged

Add external data source #327

merged 12 commits into from
Aug 20, 2025

Conversation

GianlucaFicarelli
Copy link
Collaborator

@GianlucaFicarelli GianlucaFicarelli commented Aug 12, 2025 •
edited
Loading

Split from #300

Changes:

  • renamed for simplicity:
    • ExternalDataSourcePage -> ExternalUrl
    • ExternalDataSource -> ExternalSource
    • ScientificArtifactExternalDataSourcePageLink -> ScientificArtifactExternalUrlLink
  • added endpoint to create and read ScientificArtifactExternalUrlLink
  • replaced name and description in ExternalUrl with title (similar to publication, but the change can reverted if needed) -> reverted, see comments below
  • added source and source_name, see comments below
  • everyone can create a url (urls are global), but there is a basic validation
  • only a member of the same project_id of the scientific artifact can create an association
  • note that there is a strict similarity between:
    • publication <-> external_url (but the creation of publications is restricted to admin for the moment)
    • scientific_artifact_publication_link <-> scientific_artifact_external_url_link

Other:

  • minor fixes to publication filters (some fields cannot be used for filtering)

@GianlucaFicarelli GianlucaFicarelli self-assigned this Aug 12, 2025
GianlucaFicarelli
GianlucaFicarelli commented Aug 14, 2025
View reviewed changes
@GianlucaFicarelli GianlucaFicarelli marked this pull request as ready for review August 14, 2025 06:57
@GianlucaFicarelli GianlucaFicarelli changed the title WIP Add external data source Add external data source Aug 14, 2025
mgeplf
mgeplf approved these changes Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the case of the enum; code wise I it LGTM.

AurelienJaquier
AurelienJaquier reviewed Aug 18, 2025
View reviewed changes
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into external_url
82f95f1 
* origin/main:
  Add Calibration & Validation activities (#307)
  Update uv and relax uv pinning in Dockerfile (#336)
  Add filter by authorized_public and authorized_project_id (#335)
  Fix legacy attributes (#328)
@GianlucaFicarelli
Restore name and description, add source_label
ba820b6
@GianlucaFicarelli
Rename source_label to source_name
948d7ff
AurelienJaquier
AurelienJaquier approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me

@GianlucaFicarelli GianlucaFicarelli merged commit 9b85336 into main Aug 20, 2025
1 check passed
@GianlucaFicarelli GianlucaFicarelli deleted the external_url branch August 20, 2025 12:16
GianlucaFicarelli added a commit that referenced this pull request Aug 20, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into scientific-ion-channel
93cea86 
* origin/main:
  Add external data source and url (#327)
GianlucaFicarelli added a commit that referenced this pull request Aug 21, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into em_reconstruction_v2
0319c4f 
* origin/main:
  IonChannelModel inheriting from ScientificArtifact (#300)
  Add external data source and url (#327)
  Add Calibration & Validation activities (#307)
  Update uv and relax uv pinning in Dockerfile (#336)
  Add filter by authorized_public and authorized_project_id (#335)
  Fix legacy attributes (#328)
  Add circuit hierarchy endpoint (#320)
  Remove contribution from publication (#331)
GianlucaFicarelli added a commit that referenced this pull request Aug 28, 2025
@GianlucaFicarelli
Merge remote-tracking branch 'origin/main' into draft-into-morphology…
a58a81e 
…-model

* origin/main:
  Add the ability to filter by name to IonChannelModel (#338)
  IonChannelModel inheriting from ScientificArtifact (#300)
  Add external data source and url (#327)
  Add Calibration & Validation activities (#307)
  Update uv and relax uv pinning in Dockerfile (#336)
  Add filter by authorized_public and authorized_project_id (#335)
  Fix legacy attributes (#328)
  Add circuit hierarchy endpoint (#320)
  Remove contribution from publication (#331)
  Add timezone to scientific_artifact.experiment_date (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeplf mgeplf mgeplf approved these changes

@g-bar g-bar g-bar left review comments

@AurelienJaquier AurelienJaquier AurelienJaquier approved these changes

@darshanmandge darshanmandge Awaiting requested review from darshanmandge

Assignees

@GianlucaFicarelli GianlucaFicarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GianlucaFicarelli @mgeplf @g-bar @AurelienJaquier