add filters for circuit in simulation campaign #311
Conversation
bilalesi
force-pushed
the
feat/sims-filter-by-circuit
branch
from
9773916 to
17a6c0b
Compare
| @@ -18,6 +19,7 @@ | |||
| class SimulationFilterBase(NameFilterMixin, IdFilterMixin, CustomFilter): | |||
| entity_id: uuid.UUID | None = None | |||
| entity_id__in: list[uuid.UUID] | None = None | |||
| circuit: Annotated[NestedCircuitFilter | None, NestedCircuitFilterDep] = None | |||
There was a problem hiding this comment.
Although I am ok with this workaround, I am afraid that someone will decide to set a different entity in entity_id breaking this endpoint. On the other hand we control what is added in Simulation's entity_id, so we just need to be careful. However, people forget..
@GianlucaFicarelli wdyt?
There was a problem hiding this comment.
We can modify the filter when we'll allow different types of entities, but do we already know which ones to expect? Not sure how easy is to use a sort of polymorphism here, or if we need different filters.
There was a problem hiding this comment.
IDK, probably other simulations (single neuron, synaptome) will be using the same logic in the future
bilalesi
force-pushed
the
feat/sims-filter-by-circuit
branch
from
17a6c0b to
6a8c1e2
Compare
|
Can you please add.a test that covers this use case? Just to make sure we don't break it unintentionally in the future. |
forget to push them, test added |
|
@GianlucaFicarelli is this okey to be merged ? |
bilalesi
force-pushed
the
feat/sims-filter-by-circuit
branch
from
dc882b2 to
a386697
Compare
GianlucaFicarelli
changed the title
No description provided.