Look ahead dev #1371
Open
Look ahead dev #1371
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default to 135 mins if not
|
@tim2000s how is this looking in testing? Do you want it merged to floating-carbs? What are your plans for it? |
|
@tim2000s Are you still interested in this approach for 0.7.2-dev? Or should we close it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the ability to set the prediction period to a value to see how adjusting prediction affects algorithm capability. There's a check in place that ensures the minimum time period set is 135 mins following my initial round of tests.
IF no value is entered it defaults to four hours.
BAsed on floating carbs branch.