Skip to content

Conversation

kristianjf
Copy link

Changes

Adds a new transformProperty hook that allows users to modify individual property signatures within Schema Objects. This enables adding JSDoc validation annotations and other property-level modifications that can't be achieved with existing transform/postTransform hooks.

Related Issue: Resolves #2448

Features Added:

  • New transformProperty option in OpenAPITSOptions
  • Hook integration in schema-object transformer
  • Comprehensive documentation with JSDoc validation examples
  • Test coverage for JSDoc annotations and edge cases

How to Review

  1. Core Implementation: Review src/transform/schema-object.ts for hook integration
  2. Type Definitions: Check src/types.ts for the new interface
  3. Documentation: Review docs/node.md for examples and explanations
  4. Tests: Run pnpm test to verify new test cases pass

Key files to focus on:

  • src/transform/schema-object.ts - Main implementation
  • docs/node.md - Documentation with examples
  • test/node-api.test.ts - Test coverage

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Kristian Francisco added 2 commits September 16, 2025 07:24
…nature modification

Adds a new transformProperty hook that allows users to modify individual property signatures within Schema Objects. This enables adding JSDoc validation annotations and other property-level modifications that can't be achieved with existing transform/postTransform hooks.

Features:
- New transformProperty option in OpenAPITSOptions
- Hook integration in schema-object transformer
- Comprehensive documentation with JSDoc validation examples
- Test coverage for JSDoc annotations and edge cases

Resolves openapi-ts#2448
@kristianjf kristianjf requested a review from a team as a code owner September 16, 2025 14:37
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for openapi-ts failed.

Name Link
🔨 Latest commit fcd7122
🔍 Latest deploy log https://app.netlify.com/projects/openapi-ts/deploys/68c97ca5cfb51d0008d82527

Copy link

changeset-bot bot commented Sep 16, 2025

🦋 Changeset detected

Latest commit: fcd7122

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
openapi-typescript Minor
swr-openapi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- Format transformProperty type definition for better readability
- Apply biome formatting to feature-related test code
- Keep changes focused only on transformProperty feature files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Adding validation JSDoc annotations (@minLength, @pattern, etc.) to generated TypeScript properties
1 participant