Fix Request parameter being ignored by client methods #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac3a4ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openapi-ts canceled.
|
jthacker
force-pushed
the
fix-passing-request
branch
from
d37e011 to
03fb01d
Compare
|
Note: It seems this has been broken since the introduction of the feature: #1907 |
gzm0
requested changes
Aug 12, 2025
jthacker
force-pushed
the
fix-passing-request
branch
2 times, most recently
from
c63a39c to
f889953
Compare
|
@gzm0 Thanks for the feedback. Changes pushed. Now testing for all methods and removed the duplicate test for setting |
gzm0
requested changes
Aug 13, 2025
jthacker
force-pushed
the
fix-passing-request
branch
from
f889953 to
ac3a4ef
Compare
gzm0
approved these changes
Sep 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes a bug in openapi-fetch where the client methods would ignore the
Requestparameter being passed in. Previously passing in theRequestparameter works when constructing the client but not if passed in viaGET,POST, etc. on a constructed client.Related to but not blocking #2224
How to Review
No impact to the API, adds tests for checking the functionality in both cases.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)