-
Notifications
You must be signed in to change notification settings - Fork 263
Adding a simpler "test" widget and server. #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Added a few comments to make this example consistent with the others
src/pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make it consistent with other examples, could you remove the pyproject.toml + uv.lock & .python-version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok... I've removed these files.
test_server_python/README.md
Outdated
| @@ -0,0 +1,50 @@ | |||
| ## Known issues: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Katia, @katia-openai
Given the latest merges to the openai repo - it looks like this info is no longer need.
I've removed the entire file.
test_server_python/README.md
Outdated
|
|
||
| ## Static files are used from the /static path on the MCP server | ||
|
|
||
| After running ```pnpm run build``` you need to copy all the test*.* files in the /assets directory to the /static folder under this server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to do that specifically for this example, just adding the app to build-all is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happen to be copying the files over a static folder in the MCP server so that it can be served from the server instead using a cdn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Katia, @katia-openai
Given the latest merges to the openai repo - it looks like this info is no longer need.
I've removed the entire file.
Remove 'Known issues'. I've fixed the issues.
|
Hi Katia,
I've updated the points mentioned.
I'm using the /static path on the MCP server in-place of using a cdn.
Greg
…On Wed, Oct 15, 2025 at 5:30 AM Katia Gil Guzman ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the PR! Added a few comments to make this example consistent
with the others
------------------------------
On src/pyproject.toml
<https://urldefense.com/v3/__https://github.com/openai/openai-apps-sdk-examples/pull/38*discussion_r2432364167__;Iw!!G92We9drHetJ8EofZw!dXSFSek9zUhCsT9ee7u3ygCtyfm2VRN8oCMdCbaR6TVdJn9RK8fAiAFDeGGyQx68RbYoIO_s5j6A4QLwJSXDE8OqNUg$>
:
to make it consistent with other examples, could you remove the
pyproject.toml + uv.lock & .python-version?
------------------------------
In test_server_python/README.md
<https://urldefense.com/v3/__https://github.com/openai/openai-apps-sdk-examples/pull/38*discussion_r2432367212__;Iw!!G92We9drHetJ8EofZw!dXSFSek9zUhCsT9ee7u3ygCtyfm2VRN8oCMdCbaR6TVdJn9RK8fAiAFDeGGyQx68RbYoIO_s5j6A4QLwJSXDFUoVk3w$>
:
> @@ -0,0 +1,50 @@
+## Known issues:
Can we remove this README?
------------------------------
In test_server_python/README.md
<https://urldefense.com/v3/__https://github.com/openai/openai-apps-sdk-examples/pull/38*discussion_r2432368389__;Iw!!G92We9drHetJ8EofZw!dXSFSek9zUhCsT9ee7u3ygCtyfm2VRN8oCMdCbaR6TVdJn9RK8fAiAFDeGGyQx68RbYoIO_s5j6A4QLwJSXDHWDX9pE$>
:
> @@ -0,0 +1,50 @@
+## Known issues:
+I haven't been able to get this to work yet in the 'test' widget.
+```
+ const gotoDoc = async () => {
+ // todo: this isn't working for me yet.
+ window.openai.openExternal({ "payload": "https://developers.openai.com/apps-sdk" });
+ };
+```
+
+## Static files are used from the /static path on the MCP server
+
+After running ```pnpm run build``` you need to copy all the test*.* files in the /assets directory to the /static folder under this server.
You shouldn't need to do that specifically for this example, just adding
the app to build-all is enough.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/openai/openai-apps-sdk-examples/pull/38*pullrequestreview-3340104017__;Iw!!G92We9drHetJ8EofZw!dXSFSek9zUhCsT9ee7u3ygCtyfm2VRN8oCMdCbaR6TVdJn9RK8fAiAFDeGGyQx68RbYoIO_s5j6A4QLwJSXDMVVOuz0$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAKXL4IU4WI7AVTCAXWPKPT3XY45ZAVCNFSM6AAAAACI37RLJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBQGEYDIMBRG4__;!!G92We9drHetJ8EofZw!dXSFSek9zUhCsT9ee7u3ygCtyfm2VRN8oCMdCbaR6TVdJn9RK8fAiAFDeGGyQx68RbYoIO_s5j6A4QLwJSXDg8dyCIA$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
A simpler 'Test' widget and server - showing use of the window.openai function calls from the widget.