Enhance function tool schemas with Annotated types #1777
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MuhammadHassaanArain
commented
Sep 21, 2025
MuhammadHassaanArain
commented
- Replaced plain type hints with Annotated to provide parameter descriptions
- Marked dependencies as Optional[list[str]] for flexibility
- Improved function docstrings for consistency and clarity
- No changes to streaming logic, only schema/metadata enhancements
- Replaced plain type hints with Annotated to provide parameter descriptions - Marked dependencies as Optional[list[str]] for flexibility - Improved function docstrings for consistency and clarity - No changes to streaming logic, only schema/metadata enhancements
seratch
reviewed
Sep 22, 2025
seratch
reviewed
Sep 22, 2025
seratch
approved these changes
Sep 22, 2025
Appreciate the review and for handling the lint errors this time. I’ll run lint checks locally and ensure they’re resolved in my upcoming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.