Add audio storage configuration for realtime sessions #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RealtimeAudioStorageConfig class with comprehensive audio storage options - Include configurable storage path, duration limits, format, compression, and retention - Update RealtimeRunConfig to include audio_storage_config field - Remove TODO comments and replace with proper implementation - All tests passing and code properly formatted
seratch
reviewed
Sep 22, 2025
| print("[debug] get_weather called") | ||
| return Weather(city=city, temperature_range="14-20C", conditions="Sunny with wind.") | ||
|
|
||
|
|
Comment on lines
+515
to
516
| # Audio storage config is now available in RealtimeRunConfig.audio_storage_config | ||
|
|
There was a problem hiding this comment.
Suggested change
| # Audio storage config is now available in RealtimeRunConfig.audio_storage_config |
|
Thanks for sending this PR, but it seems this is not the one we need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive audio storage configuration for realtime sessions, addressing TODO comments in the codebase.
Test plan
Issue number
Addresses TODO comments in src/agents/realtime/config.py and src/agents/realtime/session.py
Checks
make lintandmake format