Skip to content

Performance: only create the OpenAIRealtimeServerEvent TypeAdapter once #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

Performance: only create the OpenAIRealtimeServerEvent TypeAdapter once #1548

merged 1 commit into from
Aug 22, 2025

Conversation

michieldwitte
Copy link
Contributor

For every event a new TypeAdapter is created, which has a significant performance impact.
image
Creating it once and reusing it, makes event handling a lot faster.

@seratch seratch added enhancement New feature or request feature:realtime labels Aug 21, 2025
@seratch seratch requested a review from rm-openai August 21, 2025 07:52
rm-openai
rm-openai approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR. Thanks. I think you might have to rebase. Btw could also make it a module level constant (lazy loaded) instead of once per-instance (but no pressure),

@michieldwitte michieldwitte reopened this Aug 22, 2025
@rm-openai rm-openai enabled auto-merge (squash) August 22, 2025 19:02
@rm-openai rm-openai disabled auto-merge August 22, 2025 19:02
@rm-openai rm-openai merged commit 0a24671 into openai:main Aug 22, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm-openai rm-openai rm-openai approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request feature:realtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michieldwitte @rm-openai @seratch