Make Trace class inherit from abc.ABC for proper abstract base class behavior #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
approved these changes
Jul 24, 2025
rm-openai
approved these changes
Jul 25, 2025
vcshih
pushed a commit
to veris-ai/openai-agents-python
that referenced
this pull request
Aug 15, 2025
…behavior (openai#1233) The Trace class was using @abc.abstractmethod decorators without inheriting from abc.ABC, which meant the abstract methods weren't enforced. This change makes the class properly abstract while maintaining all existing functionality since no code directly instantiates Trace() - all usage goes through the concrete implementations NoOpTrace and TraceImpl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trace class was using @abc.abstractmethod decorators without inheriting
from abc.ABC, which meant the abstract methods weren't enforced.
This change makes the class properly abstract while maintaining all existing functionality
since no code directly instantiates Trace() - all usage goes through the
concrete implementations NoOpTrace and TraceImpl.