Process tokens in Context lazily #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Maratyszcza
commented
Aug 15, 2025
Maratyszcza
commented
- Process tokens when Context.process or Context.sample is called rather than when we accumulate max_batch_tokens unprocessed tokens.
- Avoid re-creating command buffers for each batch.
- Avoid redundantly computing output activations for the last token in each batch.
- Avoid invalidating KV cache on Context.reset. Match longest common prefix to tokens in KV cache when tokens are appended following Context.reset.
- Process tokens when Context.process or Context.sample is called rather than when we accumulate max_batch_tokens unprocessed tokens. - Avoid re-creating command buffers for each batch. - Avoid redundantly computing output activations for the last token in each batch. - Avoid invalidating KV cache on Context.reset. Match longest common prefix to tokens in KV cache when tokens are appended following Context.reset.
Maratyszcza
force-pushed
the
marat/lazy-process
branch
from
3345a5e to
e1770f0
Compare
dkundel-openai
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.