fix: remove extraneous reasoning parameter on non-supported models #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
흔적을남기다 |
rsrrrrrr
approved these changes
May 31, 2025
yuan-alex
force-pushed
the
alex/fix-remove-extraneous-reasoning
branch
from
7ec59c5 to
2c310cb
Compare
Author
|
Closing this PR as it's been recently implemented in #1199. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all requests made to the Responses API include a reasoning parameter that is not supported with non-reasoning models such as
gpt-4.1. This PR removes the reasoning parameter for models that don't begin withoorcodex. A similar fix already exists in #993 but I'd prefer if we'd get the fix merged in first.