Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
use opentelemetry_appender_tracing::layer;
use opentelemetry_sdk::logs::SdkLoggerProvider;
use tracing::info;
use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt};

#[test]
fn test_no_stack_overflow_when_event_is_emitted_after_shutdown() {
let exporter = opentelemetry_stdout::LogExporter::default();
let provider: SdkLoggerProvider = SdkLoggerProvider::builder()
.with_batch_exporter(exporter)
.build();

let otel_layer = layer::OpenTelemetryTracingBridge::new(&provider);

tracing_subscriber::registry().with(otel_layer).init();

provider.shutdown().unwrap();

info!("Don't crash")
}
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/logs/logger.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl opentelemetry::logs::Logger for SdkLogger {

/// Emit a `LogRecord`.
fn emit(&self, mut record: Self::LogRecord) {
if Context::is_current_telemetry_suppressed() {
if Context::is_current_telemetry_suppressed() || self.provider.is_shutdown() {
Copy link
Contributor Author

@lucamuscat lucamuscat Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also suppresses the warning logs emitted when a log is sent after the LoggerProvider is shutdown, effectively hiding the log.

return;
}
let provider = &self.provider;
Expand Down
4 changes: 4 additions & 0 deletions opentelemetry-sdk/src/logs/logger_provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ impl SdkLoggerProvider {
pub fn shutdown(&self) -> OTelSdkResult {
self.shutdown_with_timeout(Duration::from_secs(5))
}

pub(crate) fn is_shutdown(&self) -> bool {
self.inner.is_shutdown.load(Ordering::SeqCst)
}
}

#[derive(Debug)]
Expand Down
Loading