Python 3.12 compat.: LogRecord now has a taskName attribute #3557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
approved these changes
Nov 27, 2023
Fixes open-telemetry#3370. This fix was suggested by @mariojonke in open-telemetry#3370 (comment).
ocelotl
force-pushed
the
logging-taskname
branch
from
de31d6c to
08b481f
Compare
ocelotl
added
the
Approve Public API check
ocelotl
approved these changes
Dec 7, 2023
This was referenced Jan 3, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3370.
This fix was suggested by @mariojonke in #3370 (comment).
The
taskNameattribute added in Python 3.12 is documented in https://docs.python.org/3/library/logging.html#logrecord-attributes.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Patched the Fedora Linux package and confirmed that
TestLoggingInit.test_logging_init_exporternow passes.You can verify it without using Fedora by running the tests however you normally do, but using Python 3.12.
Does This PR Require a Contrib Repo Change?
Checklist: