Skip to content

Conversation

@jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Jan 5, 2024

Description

Add tox 3.12 support

Does This PR Require a Core Repo Change?

open-telemetry/opentelemetry-python#3616

@jeremydvoss
Copy link
Contributor Author

#1415

@jeremydvoss jeremydvoss marked this pull request as ready for review May 16, 2024 17:58
@jeremydvoss jeremydvoss requested a review from a team May 16, 2024 17:58
package: "sklearn"
- python-version: py311
# package: "sklearn"
# - python-version: py312
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this "exclude section"

Copy link
Contributor

@xrmx xrmx May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to be excluded, tests fails too trying to bump to scikit-learn 1.0.x (that is still an old version)

- python-version: py311
package: "prometheus-remote-write"
# - python-version: py312
# package: "prometheus-remote-write"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this "exclude section"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test works fine here with python 3.12. Plenty of warnings but tox is happy

===================================================== 27 passed, 345 warnings in 0.07s =====================================================
  py312-test-exporter-prometheus-remote-write: OK (17.43=setup[1.48]+cmd[3.12,2.86,3.18,2.97,3.47,0.35] seconds)

@jeremydvoss
Copy link
Contributor Author

Boto failing. Maybe it's related to this. Maybe we need to update: boto/botocore#2979

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added fixes for 2 of the failures here #2529, for the others failures I've added comments

"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work with that and there aren't newer releases


; opentelemetry-instrumentation-kafka-python
py3{8,9,10,11}-test-instrumentation-kafka-python
py3{8,9,10,11,12}-test-instrumentation-kafka-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work with that

- python-version: py311
# package: "sklearn"
# - python-version: py312
package: "sklearn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add

          - python-version: py312
            package: "kafka-python"
          - python-version: py312
            package: "boto"

"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boto is abandonded and so won't work with 3.12


; opentelemetry-instrumentation-boto
py3{8,9,10,11}-test-instrumentation-boto
py3{8,9,10,11,12}-test-instrumentation-boto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boto is abandonded and won't support 3.12

@xrmx xrmx mentioned this pull request Jun 3, 2024
11 tasks
@jeremydvoss
Copy link
Contributor Author

closing in favor or @xrmx's #2572

@jeremydvoss jeremydvoss closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants