fix: Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altinokdarici
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 146 146
Lines 7491 7491
Branches 1501 1501
=======================================
Hits 6819 6819
Misses 672 672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Although @opentelemetry/api is in devDependencies, @opentelemetry/api is missing in @opentelemetry/resource-detector-azure's peerDependencies. This cause failures in strict installation layout for some package managers.
Short description of the changes
Add @opentelemetry/api as peerDependencies in @opentelemetry/resource-detector-azure