-
Notifications
You must be signed in to change notification settings - Fork 611
Closed
Labels
Description
I've noticed that the undici instrumentation sets the url.full
attribute but does not set the http.url
attribute which I would expect for HTTP client spans.
It only sets these attributes:
opentelemetry-js-contrib/plugins/node/instrumentation-undici/src/undici.ts
Lines 178 to 185 in 9dc58af
const attributes: Attributes = { | |
[SemanticAttributes.HTTP_REQUEST_METHOD]: requestMethod, | |
[SemanticAttributes.HTTP_REQUEST_METHOD_ORIGINAL]: request.method, | |
[SemanticAttributes.URL_FULL]: requestUrl.toString(), | |
[SemanticAttributes.URL_PATH]: requestUrl.pathname, | |
[SemanticAttributes.URL_QUERY]: requestUrl.search, | |
[SemanticAttributes.URL_SCHEME]: urlScheme, | |
}; |