Skip to content

[service/internal/graph] Add size throughput metrics #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented May 13, 2025

Follows #12812

This PR adds the size metrics defined in the Pipeline Component Telemetry RFC.

@djaglowski
Copy link
Member Author

cc @codeboten @mx-psi

@djaglowski djaglowski force-pushed the pipeline-throughput branch from ff4e25a to dee81c1 Compare May 13, 2025 17:43
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.59%. Comparing base (e9f3dec) to head (ff7fd74).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13032      +/-   ##
==========================================
+ Coverage   91.53%   91.59%   +0.05%     
==========================================
  Files         504      505       +1     
  Lines       28154    28326     +172     
==========================================
+ Hits        25772    25944     +172     
  Misses       1873     1873              
  Partials      509      509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djaglowski djaglowski force-pushed the pipeline-throughput branch 5 times, most recently from 57af3c5 to eb97529 Compare May 14, 2025 17:25
@djaglowski djaglowski changed the title Add size throughput metrics [service/internal/graph] Add size throughput metrics May 14, 2025
@djaglowski djaglowski marked this pull request as ready for review May 14, 2025 18:23
@djaglowski djaglowski requested a review from a team as a code owner May 14, 2025 18:23
@djaglowski djaglowski requested a review from TylerHelmuth May 14, 2025 18:23
mx-psi
mx-psi previously approved these changes May 15, 2025
@djaglowski djaglowski force-pushed the pipeline-throughput branch from eb97529 to 4c37d07 Compare May 15, 2025 17:01
@mx-psi
Copy link
Member

mx-psi commented May 16, 2025

cc @open-telemetry/collector-approvers I will merge this next Tuesday unless somebody objects before then

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about how these metrics are supposed to be enabled/disabled, see comments.

If the intent is to enable these metrics based on verbosity level like we do for the byte-based metrics in the batch processor, shouldn't there be a change in configureViews in service/service.go?

@mx-psi mx-psi dismissed their stale review May 16, 2025 10:24

Concerns raised by Jade are valid

@djaglowski
Copy link
Member Author

If the intent is to enable these metrics based on verbosity level like we do for the byte-based metrics in the batch processor, shouldn't there be a change in configureViews in service/service.go?

My concern is only that these metrics exist and can be enabled by users. I will update the PR to follow the pattern used by the byte-based metrics in batch processor.

@djaglowski djaglowski force-pushed the pipeline-throughput branch from 9d6697d to ff7fd74 Compare May 16, 2025 17:59
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi
Copy link
Member

mx-psi commented May 20, 2025

@dmitryax I am going to merge this since the unit tests show that the counter is not incremented when enabled is false and all the Size calls are guarded with checks to isEnabled. If you find anything that looks wrong I can take over if Dan is no longer around

@mx-psi mx-psi added this pull request to the merge queue May 20, 2025
Merged via the queue into open-telemetry:main with commit 178caa1 May 20, 2025
56 checks passed
@djaglowski djaglowski deleted the pipeline-throughput branch May 20, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants