-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[service/internal/graph] Add size throughput metrics #13032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff4e25a
to
dee81c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13032 +/- ##
==========================================
+ Coverage 91.53% 91.59% +0.05%
==========================================
Files 504 505 +1
Lines 28154 28326 +172
==========================================
+ Hits 25772 25944 +172
Misses 1873 1873
Partials 509 509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
57af3c5
to
eb97529
Compare
eb97529
to
4c37d07
Compare
cc @open-telemetry/collector-approvers I will merge this next Tuesday unless somebody objects before then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about how these metrics are supposed to be enabled/disabled, see comments.
If the intent is to enable these metrics based on verbosity level like we do for the byte-based metrics in the batch processor, shouldn't there be a change in configureViews
in service/service.go
?
My concern is only that these metrics exist and can be enabled by users. I will update the PR to follow the pattern used by the byte-based metrics in batch processor. |
9d6697d
to
ff7fd74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dmitryax I am going to merge this since the unit tests show that the counter is not incremented when enabled is false and all the |
Follows #12812
This PR adds the
size
metrics defined in the Pipeline Component Telemetry RFC.