Skip to content

[chore] Update attribute name in rfc #12951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

[chore] Update attribute name in rfc #12951

merged 1 commit into from
May 1, 2025

Conversation

djaglowski
Copy link
Member

Resolves #12916

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (045488f) to head (51451bf).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12951   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         503      503           
  Lines       27550    27550           
=======================================
  Hits        25262    25262           
  Misses       1808     1808           
  Partials      480      480

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djaglowski djaglowski marked this pull request as ready for review April 30, 2025 19:43
@djaglowski djaglowski requested a review from a team as a code owner April 30, 2025 19:43
@djaglowski djaglowski mentioned this pull request Apr 30, 2025
Closed
@codeboten codeboten added this pull request to the merge queue May 1, 2025
Merged via the queue into open-telemetry:main with commit ca612c0 May 1, 2025
68 of 74 checks passed
@djaglowski djaglowski deleted the pipeline-telemetry-rfc-outcome branch May 2, 2025 06:07
@djaglowski djaglowski mentioned this pull request May 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 5, 2025
@djaglowski
[chore] Update obsconsumer to use new attribute name (#12959)
56c7da2 
Implements new name for attribute as documented in #12951.

Note: The obsconsumer package is unused until #12812 is merged so this
is not a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The outcome attribute in Pipeline Component Telemetry RFC isn't scoped
2 participants
@djaglowski @codeboten