Statically validate connector config during dry-run. #12712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudiptob2
force-pushed
the
feat/config-validation-graph-ins
branch
from
ee5e5cd to
92d543e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12712 +/- ##
==========================================
+ Coverage 91.43% 91.44% +0.01%
==========================================
Files 487 487
Lines 26811 26846 +35
==========================================
+ Hits 24514 24549 +35
Misses 1814 1814
Partials 483 483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc: @djaglowski @mx-psi |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmathieu
reviewed
Apr 8, 2025
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
sudiptob2
force-pushed
the
feat/config-validation-graph-ins
branch
from
92d543e to
5884efd
Compare
dmathieu
approved these changes
Apr 9, 2025
djaglowski
approved these changes
Apr 9, 2025
mx-psi
approved these changes
Apr 9, 2025
This was referenced Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #8721, the current
validatecommand cannot capture improper connector usage errors during a dry run.One proposed solution (as mentioned in this comment) is to surface configuration errors by instantiating the service during the dry run. However, reviewers preferred statically verifying the errors over instantiating the service (see the PR #12488 comments).
The validation logic for connectors is located in the
service/internal/graphpackage. In the discussion of PR #12681, it was concluded that instantiating the graph is the better approach (see this comment).Finally, this PR uses the
graph.Build()method to surface configuration errors during the dry run.Link to tracking issue
Fixes #8721 #12535
Testing
Documentation