[extension/storage/redisstorageextension] Add TLS support #40185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjpin
changed the title
gjpin
changed the title
atoulme
reviewed
May 22, 2025
atoulme
reviewed
May 22, 2025
atoulme
reviewed
May 22, 2025
|
Please add a changelog by typing from the root of the checkout |
|
Please address the comments and mark ready for review again. |
atoulme
reviewed
May 22, 2025
atoulme
reviewed
May 22, 2025
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
|
Please resolve conflicts and I will take a final look. |
|
Conflicts resolved. |
|
Sorry, we had a release and your added dependencies clash with the new set. Please run |
No problem at all! Done. |
atoulme
added
the
ready to merge
atoulme
approved these changes
May 28, 2025
atoulme
reviewed
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TLS support to Redis storage extension (extension/storage/redisstorageextension).
Issue number
N/A - Couldn't find any relevant open issue.
Testing
Connected the Redis storage extension to a AWS ElastiCache Valkey serverless instance, which has mandatory TLS usage.
Automated tests were also changed to account for TLS config and are passing.
Documentation
Added documentation to the component on how to use TLS config.