elasticsearchexporter: mapping mode from scope #39110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
elasticsearchexporter-scopeattr-mappingmode
branch
from
f9f842f to
14b98fe
Compare
axw
force-pushed
the
elasticsearchexporter-scopeattr-mappingmode
branch
from
14b98fe to
e71b432
Compare
Add support for specifying the mapping mode as a scope attribute, "elastic.mapping.mode". If specified, this overrides X-Elastic-Mapping-Mode. Simplify StartSession by removing the error result, since the only time it can fail is if the BulkIndexerConfig is invalid, and we ensure that cannot happen. We now also pre-create arrays of encoders, routers, and data point hashers. This simplifies and speeds up acquisition of these during execution.
axw
force-pushed
the
elasticsearchexporter-scopeattr-mappingmode
branch
from
e71b432 to
6cf7592
Compare
carsonip
reviewed
Apr 14, 2025
|
@carsonip done, PTAL |
exporter/elasticsearchexporter/internal/serializer/otelserializer/common.go
Show resolved
Hide resolved
andrzej-stencel
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for specifying the mapping mode as a scope attribute, "elastic.mapping.mode". If specified, this overrides both X-Elastic-Mapping-Mode from client metadata as well as the default mode specified through collector configuration.
Simplify StartSession by removing the error result, since the only time it can fail is if the BulkIndexerConfig is invalid, and we ensure that cannot happen. We now also pre-create arrays of encoders, routers, and data point hashers; this simplifies and speeds up acquisition of these during execution.
This is based on #38667
Link to tracking issue
N/A
Testing
Added unit tests.
Documentation
Updated README.