Skip to content

[exporter/elasticsearch] Feed the symbolization queues #38577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 19, 2025

Conversation

rockdaboot
Copy link
Contributor

Start writing data into the symbolization queues, so that symbolization of frames can be done by the Elastic profiling symbolizer. Symbolization is the process that turns addresses into symbols (mostly function names). Without symbols, native frames mostly stay unreadable and thus unusable.

There are two queues, one for leaf frames and one for executables.

@rockdaboot rockdaboot force-pushed the esex-symbolization-queues branch from 40aa36e to a7bd462 Compare March 12, 2025 17:13
@rockdaboot rockdaboot marked this pull request as ready for review March 12, 2025 17:13
@rockdaboot rockdaboot requested a review from a team as a code owner March 12, 2025 17:13
@rockdaboot rockdaboot requested a review from jpkrohling March 12, 2025 17:13
@rockdaboot rockdaboot marked this pull request as draft March 12, 2025 17:15
@rockdaboot rockdaboot force-pushed the esex-symbolization-queues branch from a7bd462 to 4edc5b7 Compare March 13, 2025 11:09
@rockdaboot rockdaboot force-pushed the esex-symbolization-queues branch from 4edc5b7 to 0d590dd Compare March 13, 2025 12:20
@rockdaboot rockdaboot marked this pull request as ready for review March 13, 2025 14:10
@rockdaboot rockdaboot requested review from carsonip and dmathieu March 14, 2025 09:20
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just realized it was a test file. It would be fine either way, but thanks for making the change and making it consistent with the rest of es exporter code.

@rockdaboot
Copy link
Contributor Author

@andrzej-stencel Please take a look.

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a [chore]? Shouldn't this have a changelog entry?

@rockdaboot rockdaboot changed the title [chore] [exporter/elasticsearch] Feed the symbolization queues [exporter/elasticsearch] Feed the symbolization queues Mar 19, 2025
@rockdaboot rockdaboot marked this pull request as ready for review March 19, 2025 08:59
@rockdaboot
Copy link
Contributor Author

rockdaboot commented Mar 19, 2025

@atoulme I added the changelog and removed chore status from title.

@atoulme
Copy link
Contributor

atoulme commented Mar 19, 2025

Changelog is in, merging.

@atoulme atoulme merged commit 4bfdbfb into open-telemetry:main Mar 19, 2025
174 of 175 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 19, 2025
lightme16 pushed a commit to lightme16/opentelemetry-collector-contrib that referenced this pull request Mar 19, 2025
…y#38577)

Start writing data into the symbolization queues, so that symbolization
of frames can be done by the Elastic profiling symbolizer. Symbolization
is the process that turns addresses into symbols (mostly function
names). Without symbols, native frames mostly stay unreadable and thus
unusable.

There are two queues, one for leaf frames and one for executables.
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
…y#38577)

Start writing data into the symbolization queues, so that symbolization
of frames can be done by the Elastic profiling symbolizer. Symbolization
is the process that turns addresses into symbols (mostly function
names). Without symbols, native frames mostly stay unreadable and thus
unusable.

There are two queues, one for leaf frames and one for executables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants