-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[exporter/elasticsearch] Feed the symbolization queues #38577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Feed the symbolization queues #38577
Conversation
40aa36e
to
a7bd462
Compare
a7bd462
to
4edc5b7
Compare
4edc5b7
to
0d590dd
Compare
exporter/elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/model.go
Show resolved
Hide resolved
exporter/elasticsearchexporter/internal/serializer/otelserializer/profile.go
Outdated
Show resolved
Hide resolved
...rter/elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/transform.go
Outdated
Show resolved
Hide resolved
...elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/transform_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
...elasticsearchexporter/internal/serializer/otelserializer/serializeprofiles/transform_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized it was a test file. It would be fine either way, but thanks for making the change and making it consistent with the rest of es exporter code.
@andrzej-stencel Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it a [chore]? Shouldn't this have a changelog entry?
@atoulme I added the changelog and removed chore status from title. |
Changelog is in, merging. |
…y#38577) Start writing data into the symbolization queues, so that symbolization of frames can be done by the Elastic profiling symbolizer. Symbolization is the process that turns addresses into symbols (mostly function names). Without symbols, native frames mostly stay unreadable and thus unusable. There are two queues, one for leaf frames and one for executables.
…y#38577) Start writing data into the symbolization queues, so that symbolization of frames can be done by the Elastic profiling symbolizer. Symbolization is the process that turns addresses into symbols (mostly function names). Without symbols, native frames mostly stay unreadable and thus unusable. There are two queues, one for leaf frames and one for executables.
Start writing data into the symbolization queues, so that symbolization of frames can be done by the Elastic profiling symbolizer. Symbolization is the process that turns addresses into symbols (mostly function names). Without symbols, native frames mostly stay unreadable and thus unusable.
There are two queues, one for leaf frames and one for executables.