[elasticsearchexporter] Use new exporterbatcher.SizeConfig #38243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
elasticsearchexporter-sizeconfig
branch
from
ccb339d to
8bfb7af
Compare
axw
force-pushed
the
elasticsearchexporter-sizeconfig
branch
from
8bfb7af to
c271783
Compare
lahsivjar
approved these changes
Feb 27, 2025
carsonip
approved these changes
Feb 27, 2025
dmitryax
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated BatcherConfig to support the new SizeConfig, which replaces the now-deprecated MinSizeItems and MaxSizeItems. BatcherConfig now embeds the exporterbatcher.Config and sets an additional unexported field to track whether
batcher::enabledhas been set.See open-telemetry/opentelemetry-collector#12486
Link to tracking issue
N/A
Testing
Added unit test
Documentation
Updated README.